Xfce Forum

aus9

Member

From: Perth, Australia

Registered: 2018-01-11

Posts: 22

[SOLVED] xfdesktop make error, needed gtk3 patch

Hi

I can compile the stable branch 4.12.4 but indications from the distro maintainer, for TinyCoreLInux is that it is unlikely to be accepted as it required the building of libwnck for older release....and so it did not conflict with libwnck build to prefix=/usr/local
---I built a special libwnck with prefix=/usr

That is,  existing libwnck compiled with prefix=/usr/local is thought to conflict with a package I renamed usrwnck compiled with prefix=/usr
And if I were to submit with above packages repo would have TWO libwncks.

So I attempted to compile either the 4.13.0 or 4.13.1.

both configure with a configure line of
./configure --disable-debug --enable-thunarx

with
#    Build Configuration:

# Build desktop menu module:                    yes
# Build support for desktop icons:              yes
#     Include support for file/launcher icons:  yes
# Mount notification support:                   yes

the last lines of make error are:

/usr/local/include/glib-2.0/glib/glist.h:82:10: note: expected 'GList * {aka struct _GList *}' but argument is of type 'int'
 GList*   g_list_concat                  (GList            *list1,
          ^~~~~~~~~~~~~
  CC       xfdesktop-xfdesktop-regular-file-icon.o
  CC       xfdesktop-xfdesktop-special-file-icon.o
  CC       xfdesktop-xfdesktop-volume-icon.o
  CCLD     xfdesktop
xfdesktop-xfdesktop-file-icon-manager.o: In function `xfdesktop_file_icon_manager_populate_context_menu':
xfdesktop-file-icon-manager.c:(.text+0x2fbd): undefined reference to `thunarx_menu_provider_get_folder_actions'
xfdesktop-file-icon-manager.c:(.text+0x2fe9): undefined reference to `thunarx_menu_provider_get_file_actions'
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:647: xfdesktop] Error 1
make[3]: Leaving directory '/tmp/xfdesktop-4.13.1/src'
make[2]: *** [Makefile:562: all] Error 2
make[2]: Leaving directory '/tmp/xfdesktop-4.13.1/src'
make[1]: *** [Makefile:573: all-recursive] Error 1
make[1]: Leaving directory '/tmp/xfdesktop-4.13.1'
make: *** [Makefile:484: all] Error 2

Anyone know how to resolve this make error?

thanks for reading

Last edited by aus9 (2018-01-25 09:39:16)

ToZ

Administrator

From: Canada

Registered: 2011-06-02

Posts: 11,523

Re: [SOLVED] xfdesktop make error, needed gtk3 patch

So I attempted to compile either the 4.13.0 or 4.13.1.
.....
xfdesktop-file-icon-manager.c:(.text+0x2fbd): undefined reference to `thunarx_menu_provider_get_folder_actions'
xfdesktop-file-icon-manager.c:(.text+0x2fe9): undefined reference to `thunarx_menu_provider_get_file_actions'

xfdesktop and thunarx are out of sync in those versions. If you want them to compile, make sure you apply the thunarx-3 patch. Or build from git (where the patch has already been committed). Although, I'm not sure you want to include a development/git version in a distro release.

Note that xfdesktop 4.13.x is the GTK3 build of xfdesktop - which is toolkit-different than the GTK2-based 4.12.x series.

---

Please remember to mark your thread [SOLVED] to make it easier for others to find
--- How To Ask For Help | FAQ | Developer Wiki  |  Community | Contribute ---

aus9

Member

From: Perth, Australia

Registered: 2018-01-11

Posts: 22

Re: [SOLVED] xfdesktop make error, needed gtk3 patch

Hi

wonderful

initially looking at the word "git" in the patch file I thought I might have to use git apply command but  patch worked instead.
showing I am good boy and building to gtk3. The packages named have their own list of building dependencies.

(snip)P=xfdesktop
V=4.13.1
USER=`cat /etc/sysconfig/tcuser`
LIST="compiletc submitqc intltool libX11-dev glib2-dev gtk3-dev libwnck-dev \
libxfce4util-dev libxfce4ui-dev exo-dev libnotify-dev Thunar-dev"
(snip)
su -c "/usr/local/bin/wget -nc --no-check-certificate \
https://git.xfce.org/xfce/$P/patch/\
?id=4c77522252500818869654832594a2d38c3dc291 -O gtk3.patch" $USER
mkdir $P
tar jxvf $P*bz2
cp gtk3.patch $P-$V
cd $P-$V
patch -p1 < gtk3.patch
## patching file src/xfdesktop-file-icon-manager.c
./configure --disable-debug --enable-thunarx 
#####################################
#    Build Configuration:

# Build desktop menu module:                    yes
# Build support for desktop icons:              yes
#     Include support for file/launcher icons:  yes
# Mount notification support:                   yes
#####################################################
make -j5
make install-strip DESTDIR=/tmp/$P
(snip)

package is built and testing to start, more packages to build but its looking awefully cool thanks to your quick reply and very helpful knowledge to know what patch I needed.

marked as solved thanks

Last edited by aus9 (2018-01-25 09:54:24)