Xfce Forum

-iak-

Member

Registered: 2017-10-30

Posts: 99

Edited xfwm theme looks like the original (!)

Hi everybody, I downloaded an xfwm theme called RGaps [https://www.xfce-look.org/p/1174081/].
The author says that he uses Oomox [https://github.com/themix-project/oomox] to generate different colour schemes.
I installed it and I really like it for the things that it allows to do, but unfortunately I wasn't able to use it to edit the RGaps themes.

So I decided to manually edit the themes, editing the hexadecimal values in the .xpm files. The files look now different in the Tunar's tumbnail.
I created a new folder in /usr/share/themes, with an "xfwm" folder in it. In fact, the new theme is recognized and usable, but, weird thing, it looks exactly like the original RGaps theme.

Why is this happening?

Thanks in advance,
Andrea

Last edited by -iak- (2019-07-08 22:16:49)

ToZ

Administrator

From: Canada

Registered: 2011-06-02

Posts: 11,482

Re: Edited xfwm theme looks like the original (!)

Hard to tell without seeing the changes you made, but the RGaps theme uses the GTK Color Pickup functionality of xfwm4. Basically, it will use the GTK-defined colour in place of the coded colour. My best guess is that this is what is happening. If you want  to enforce a colour, you'll need to remove the colour pickup codes. For example, title-3-active.xpm:

/* XPM */
static char * title_3_active_xpm[] = {
"1 27 2 1",
"#	c #000000 s active_color_2",
" 	c None",
" ",
" ",
" ",
" ",
" ",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#",
"#"};
/* RMG 20170401 */

...specifies "active_color_2" as the colour pickup code, and according to the xfwm4 colour conversion guide from the link above, it will use "bg[normal]" of your GTK2 theme.

To get around this, you need to edit every xpm file and remove the pickup code:

"#    c #000000 s active_color_2",

...becomes:

"#	c #000000",

EDIT: These colours can also be defined in the themerc file, but this theme looks like it only affects the titlebar labels with this file.

Last edited by ToZ (2019-07-08 22:48:19)

---

Please remember to mark your thread [SOLVED] to make it easier for others to find
--- How To Ask For Help | FAQ | Developer Wiki  |  Community | Contribute ---

-iak-

Member

Registered: 2017-10-30

Posts: 99

Re: Edited xfwm theme looks like the original (!)

Thank you, ToZ.
So, the "s active_color_2" thing should let the xfwm theme use the default colour of the main theme? Is it's so, it's not happening, RGaps is always the same.

Anyway, by removing it, it works. Thanks a lot!

P.S.
Is there any trick to avoid to manually edit every single file?

Last edited by -iak- (2019-07-08 23:43:48)

-iak-

Member

Registered: 2017-10-30

Posts: 99

Re: Edited xfwm theme looks like the original (!)

I tried

find . -name '*-active*' -exec sed "s/#999999/#126d7a/g" {} \;

but surprisingly it didn't affect any file

ToZ

Administrator

From: Canada

Registered: 2011-06-02

Posts: 11,482

Re: Edited xfwm theme looks like the original (!)

You didn't specify inline edit "-i". Try:

find . -name '*-active*' -exec sed -i "s/#999999/#126d7a/g" {} \;

---

Please remember to mark your thread [SOLVED] to make it easier for others to find
--- How To Ask For Help | FAQ | Developer Wiki  |  Community | Contribute ---

-iak-

Member

Registered: 2017-10-30

Posts: 99

Re: Edited xfwm theme looks like the original (!)

Yes, it works, thank you very much!