Xfce Forum

kontrapupix

Member

Registered: 2010-10-13

Posts: 5

Terminal do not change tab name

I work in Slackware 13.1 with XFCE 4.6.1
I edit text in Terminal in any tabs. But I can't change tab name of Terminal. When I type text of the tab name - it changes in tab is, but when I press Enter, name of tab do not applied. Help me please to solve this problem.
Thank you very much !

gnome_refugee

Member

Registered: 2010-01-15

Posts: 169

Re: Terminal do not change tab name

Are using xfce4-terminal? In xfce4-terminal, you name a tab using Set Title... in the Terminal menu (Alt t s). This brings up a dialog box where you enter the tab name. Click Close (or Alt c) and the tab name will stick.

kontrapupix

Member

Registered: 2010-10-13

Posts: 5

Re: Terminal do not change tab name

Yes, it is simple xfce4-terminal, but it name "Terminal" in system

bash-4.1$ whereis Terminal
Terminal: /usr/bin/Terminal /usr/X11R6/bin/Terminal /usr/bin/X11/Terminal /usr/X11/bin/Terminal /usr/share/Terminal /usr/man/man1/Terminal.1.gz /usr/share/man/man1/Terminal.1.gz /usr/X11/man/man1/Terminal.1.gz

In "About":
Terminal
0.4.4
terminal for Xfce

I do it (naming tabs), how you write. But Terminal ignores this.

gnome_refugee

Member

Registered: 2010-01-15

Posts: 169

Re: Terminal do not change tab name

My Terminal version is 0.4.2

I don't see a tabs bug in Xfce Bugzilla (http://bugzilla.xfce.org/query.cgi), so maybe it's new? You could also try the next version, available here:

http://packages.debian.org/squeeze/xfce4-terminal

Xfce forum members: anyone else have this problem?

kontrapupix

Member

Registered: 2010-10-13

Posts: 5

Re: Terminal do not change tab name

Thank You for your answer! I installed 0.4.5  version of Terminal (it really name "Terminal") successfully, but the tab's problem not solved!
Unfortunately, this function I really need  :-(

GS

Member

From: place once called Transylvania

Registered: 2010-06-23

Posts: 41

Re: Terminal do not change tab name

My Terminal version is 0.4.2

I don't see a tabs bug in Xfce Bugzilla (http://bugzilla.xfce.org/query.cgi), so maybe it's new? You could also try the next version, available here:

http://packages.debian.org/squeeze/xfce4-terminal

Xfce forum members: anyone else have this problem?

I'm running 0.4.5 version of terminal in Debian  testing / Xfce 4.6.2. I see no such issue.

To determine whether the OP problem is systemic or a fluke in user account configuration, I wonder if kontrapupix has tested terminal under another user account.

kontrapupix

Member

Registered: 2010-10-13

Posts: 5

Re: Terminal do not change tab name

I'm running Terminal (0.4.4) under root user (with uid 0). Result is not changed.

GS

Member

From: place once called Transylvania

Registered: 2010-06-23

Posts: 41

Re: Terminal do not change tab name

So, you're launching the terminal always from within the same user account?

It's odd. I seem to remember something like this happening to me a couple of years ago. But I'm sure that was with another terminal emulator. (I wasn't using Xfce then.)

kontrapupix

Member

Registered: 2010-10-13

Posts: 5

Re: Terminal do not change tab name

Yes, I run the terminal emulator under my user always. But when I run KDE Konsole emulator, it works normally and Konsole - tabs work normally. I will try install the Terminal emulator 0.4.2 version.

sukaeto

Member

Registered: 2011-01-02

Posts: 1

Re: Terminal do not change tab name

Hi,

First off, sorry for necro-posting.  Also, I'm sorry if this has already been fixed in the latest development version since we're talking about an old version here . . .

But, I can confirm this bug on Slackware 13.1 as well.  I looked into the source, and AFAICT (I don't really know much about GTK or XFCE's libs) the cause of the problem is that as the text entry box is being destroyed, its text field is set to NULL.  This coupled with the fact that the tab title and the entry text are bound together with exo_mutual_binding_new causes the tab's title to always be reset to the default 'Untitled' when you close the set text dialog.

I have a patch here for Terminal 0.4.5 which fixes the problem (again, sorry if there's a newer stable by now - I grabbed the sources off the Debian link provided by gnome_refugee.)  Here it is:

--- terminal-window.c    2010-05-21 16:09:57.000000000 -0400
+++ ../../Terminal-0.4.5-fixed/terminal/terminal-window.c    2011-01-01 21:30:28.720451135 -0500
@@ -1520,8 +1520,9 @@
 
 
 static void
-title_dialog_response (GtkWidget *dialog,
-                       gint       response)
+title_dialog_response (GtkWidget        *dialog,
+                       gint              response,
+                       ExoMutualBinding *text_binding)
 {
   /* check if we should open the user manual */
   if (response == GTK_RESPONSE_HELP)
@@ -1531,24 +1532,34 @@
     }
   else
     {
+      /* unbind the dialog entry text from the window title so that closing the
+       * dialog does not cause the title text to be reset. */
+      exo_mutual_binding_unbind(text_binding);
+
       /* close the dialog */
       gtk_widget_destroy (dialog);
     }
 }
 
+static void
+title_dialog_emit_response (GtkWidget *dialog)
+{
+  g_signal_emit_by_name (dialog, "response", GTK_RESPONSE_CLOSE);
+}
 
 
 static void
 terminal_window_action_set_title (GtkAction      *action,
                                   TerminalWindow *window)
 {
-  AtkRelationSet *relations;
-  AtkRelation    *relation;
-  AtkObject      *object;
-  GtkWidget      *dialog;
-  GtkWidget      *box;
-  GtkWidget      *label;
-  GtkWidget      *entry;
+  AtkRelationSet   *relations;
+  AtkRelation      *relation;
+  AtkObject        *object;
+  GtkWidget        *dialog;
+  GtkWidget        *box;
+  GtkWidget        *label;
+  GtkWidget        *entry;
+  ExoMutualBinding *text_binding;
 
   if (G_LIKELY (window->active != NULL))
     {
@@ -1572,7 +1583,7 @@
       entry = gtk_entry_new ();
       gtk_box_pack_start (GTK_BOX (box), entry, TRUE, TRUE, 0);
       g_signal_connect_swapped (G_OBJECT (entry), "activate",
-                                G_CALLBACK (gtk_widget_destroy), dialog);
+                                G_CALLBACK (title_dialog_emit_response), dialog);
       gtk_widget_show (entry);
 
       /* set Atk description and label relation for the entry */
@@ -1583,10 +1594,10 @@
       atk_relation_set_add (relations, relation);
       g_object_unref (G_OBJECT (relation));
 
-      exo_mutual_binding_new (G_OBJECT (window->active), "custom-title", G_OBJECT (entry), "text");
+      text_binding = exo_mutual_binding_new (G_OBJECT (window->active), "custom-title", G_OBJECT (entry), "text");
 
       g_signal_connect (G_OBJECT (dialog), "response",
-                        G_CALLBACK (title_dialog_response), NULL);
+                        G_CALLBACK (title_dialog_response), text_binding);
 
       gtk_widget_show (dialog);
     }

Hopefully this'll find its way to the right person if it ends up being important.

Cheers,

Nick

Dev

From: ~

Registered: 2005-02-17

Posts: 1,144

Website

Re: Terminal do not change tab name

Fixed in master and released in 0.4.6.

Last edited by Nick (2011-01-30 20:39:06)

---

G+ Profile - Ohloh Profile